keyparams: fix broken.

Issues reported by user vapnik spaknik. The evaluation of init
forms is incorrect. Init forms like '(x) evaluate to
'(x) rather than (x), Also, init forms are evaluated even when
the argument is present, so the entire current approach is
wrong.

* stdlib/keyparams.tl (extract-keys, extract-keys-p,
build-key-list-expr): Functions removed.
(stuff-key-params): New function.
(:key): Rework using simplified approach, with just the
stuff-key-params helper. All variables from the keyword
parameter list are bound with let. Generated code searches
the keyword parameters for values and assigns the variables as
needed, evaluating default init forms in the not-found cases.

* tests/011/keyparams.tl: New file.

1 files changed, 38 insertions, 0 deletions

diff --git a/tests/011/keyparams.tl b/tests/011/keyparams.tl
new file mode 100644
index 00000000..e2f8baf2
--- /dev/null
+++ b/tests/011/keyparams.tl
@@ -0,0 +1,38 @@
+(load "../common")
+
+(defvarl v :v)
+(defsymacro u (identity :u))
+
+(mtest
+  [(lambda (:key))] nil
+  [(lambda (:key a))] :error
+  [(lambda (:key a) a) 1] 1)
+
+(mtest
+  [(lambda (:key -- (a v)) a)] :v
+  [(lambda (:key -- (a 'v)) a)] v
+  [(lambda (:key -- (a v a-p)) (list a a-p))] (:v nil)
+  [(lambda (:key -- (a 'v a-p)) (list a a-p))] (v nil))
+
+(mtest
+  [(lambda (:key -- (a v)) a) :a 1] 1
+  [(lambda (:key -- (a 'v)) a) :a 1] 1
+  [(lambda (:key -- (a v a-p)) (list a a-p)) :a 1] (1 t)
+  [(lambda (:key -- (a 'v a-p)) (list a a-p)) :a 1] (1 t))
+
+(mtest
+  [(lambda (:key -- (a v) (b u)) (list a b)) :a 1] (1 :u)
+  [(lambda (:key -- (a 'v) (b 'u)) (list a b)) :b 1] (v 1)
+  [(lambda (:key -- (a v a-p) (b u b-p)) (list a a-p b b-p)) :a 1] (1 t :u nil)
+  [(lambda (:key -- (a v a-p) (b u b-p)) (list a a-p b b-p)) :b 1] (:v nil 1 t))
+
+(test
+  [(lambda (:key -- (a v) . r) (list a r)) :a 1] (1 (:a 1)))
+
+(defun key-place (:key -- x y (s nil s-p)) ^(,x ,y ,s ,s-p))
+
+(defset key-place (:key -- x y) s
+  ^(key-place :x ,x :y ,y :s ,s))
+
+(test
+  (set (key-place :x 3 :y 4) 42) (3 4 42 t))