diff options
author | Kaz Kylheku <kaz@kylheku.com> | 2022-10-31 07:18:41 -0700 |
---|---|---|
committer | Kaz Kylheku <kaz@kylheku.com> | 2022-10-31 07:18:41 -0700 |
commit | 00d7b468e94d23646bb58b1774f5bec33b7c9fb1 (patch) | |
tree | f694ebdf6167de879ea9614279bf51b50297ac4e /struct.c | |
parent | 746dddd01f28dc4499825c855c42aa5e95d5055a (diff) | |
download | txr-00d7b468e94d23646bb58b1774f5bec33b7c9fb1.tar.gz txr-00d7b468e94d23646bb58b1774f5bec33b7c9fb1.tar.bz2 txr-00d7b468e94d23646bb58b1774f5bec33b7c9fb1.zip |
crypt: remove dubious validator.
The validate_salt function was introduced in commit
c3a0ceb2cea1a9d43f2baf5a2e63d0d712c8df19, February 2020.
I cannot reproduce the internal crash in crypt which
it alleges, and I neglected to mention the bad inputs
in the commit or add tests. I'm not able to reproduce
the alleged behavior in spite of trying all sorts of bad
inputs; and looking at the crypt source in glibc, I
don't see any obvious problem.
And so, on this Halowe'en, we exorcise the ghost
that has been haunting the crypt.
* sysif.c (salt_char_p, validate_salt): Static functions
removed.
(crypt_wrap): Don't call validate_salt, and so cwsalt
need not be tested for null.
* tests/018/crypt.tl: New file.
* txr.1: Mention that crypt_r is used if available, which
avoids static storage.
Diffstat (limited to 'struct.c')
0 files changed, 0 insertions, 0 deletions