summaryrefslogtreecommitdiffstats
path: root/linenoise
diff options
context:
space:
mode:
authorKaz Kylheku <kaz@kylheku.com>2020-04-05 20:01:28 -0700
committerKaz Kylheku <kaz@kylheku.com>2020-04-05 20:01:28 -0700
commit998a47a585ae540f0f3229dcd68b3d04ac657c36 (patch)
treee4d0dc1c59f45cad31865a653fb08b28853914fa /linenoise
parent507fecc73fd4a141862861e7f4e2cc08e3fef38e (diff)
downloadtxr-998a47a585ae540f0f3229dcd68b3d04ac657c36.tar.gz
txr-998a47a585ae540f0f3229dcd68b3d04ac657c36.tar.bz2
txr-998a47a585ae540f0f3229dcd68b3d04ac657c36.zip
warning cleanup: missing member initializers.
This is the sixth round of an effort to enable GCC's -Wextra option. Warnings about uninitialized members are addressed. I am not happy with what had to be done in linenoise.c. We just need a dummy circular list node for the lino_list, which we achieved with a dummy all zero struture, with statially initialized next and prev pointers. There are way too many members to initialize, including one that has struct termios type containing a nonportable set of members. On the plus size, the lino_list structure now moves into the BSS section, reducing the executable size slightly. * lib.c (cptr_ops): Initialize using cobj_ops_init, which has all the initializers already, and should have been used for this in the first place. * linenoise/linenoise.c (lino_list): Remove initializer, which eliminates the warning about some members not being initialized. (lino_init): Initialize the next and prev pointers here. * parser.c (parser_ops): Initialize with cobj_ops_init. * stream.h (stdio_mode_init_blank, stdio_mode_init_r, stdio_mode_init_rpb): Add initializer corresponding to redir array member of struct stdio_mode. * sysif.c (cptr_dl_ops): Use cobj_ops_init. * tree.c (tree_iter_init): Add initializer for the path array member of struct tree_iter. (tr_rebuild): Initialize all fields of the dummy object. Since it's a union, we just have to deal with the any member. There are two layouts for the obj_common fields based on whether CONFIG_GEN_GC is enabled. This is ugly, but occurs in one place only.
Diffstat (limited to 'linenoise')
-rw-r--r--linenoise/linenoise.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/linenoise/linenoise.c b/linenoise/linenoise.c
index 83a08ec7..75721075 100644
--- a/linenoise/linenoise.c
+++ b/linenoise/linenoise.c
@@ -159,7 +159,7 @@ enum key_action {
};
static lino_os_t lino_os;
-static lino_t lino_list = { &lino_list, &lino_list };
+static lino_t lino_list;
volatile sig_atomic_t lino_list_busy;
static int atexit_registered = 0; /* Register atexit just 1 time. */
@@ -2840,4 +2840,5 @@ void lino_set_result(lino_t *ls, wchar_t *res)
void lino_init(lino_os_t *os)
{
lino_os = *os;
+ lino_list.next = lino_list.prev = &lino_list;
}