From fdf3fd788efb143631099c2e16636e27b3241ac3 Mon Sep 17 00:00:00 2001
From: Kaz Kylheku <kaz@kylheku.com>
Date: Wed, 7 Nov 2018 07:34:42 -0800
Subject: Better identify functions that misuse COBJ-s and hashes.

In this patch, the cobj_handle, cobj_ops and variants of
gethash get an additional argument to identify the caller.
Many functions are updated to pass this down.

* buf.c (buf_strm): Pass self name to cobj_handle.

* eval.c (env_fbind, env_vbind, rt_defvarl, me_case): Pass
self name to gethash_c or gethash_e.
(load): Pass self name to read_eval_stream and
read_compiled_file.
(reg_symacro): Pass situation-identifying string to gethash_c.

* ffi.c (ffi_type_struct_checked, ffi_closure_struct_checked,
ffi_call_desc_checked, uni_struct_checked):
Take self name parameter, and pass down to cobj_handle.
(ffi_get_type, ffi_get_lisp_type): Take self name and pass
down to ffi_type_struct_checked.
(union_get_ptr): Take self name and pass to
uni_struct_checked.
(ffi_union_in, ffi_union_put): Pass self name to union_get_ptr.
(ffi_type_compile): Pass self name to ffi_get_lisp_type.
(ffi_make_call_desc): Pass self name to
ffi_type_struct_checked, ffi_get_type and
ffi_call_desc_checked.
(ffi_make_closure): Pass self name to ffi_call_desc_checked.
(ffi_closure_get_fptr): Take self name, pass to
ffi_closure_struct_checked.
(ffi_typedef, ffi_size, ffi_alignof, ffi_offsetof,
ffi_arraysize, ffi_elemsize, ffi_elemtype, ffi_put_into,
ffi_put, ffi_in, ffi_get, ffi_out, make_carray): Pass self
name to ffi_closure_struct_checked.
(carray_struct_checked): Take self name, pass to cobj_handle.
(carray_set_length, carray_dup, carray_own, carray_free,
carray_type, length_carray, copy_carray, carray_ptr,
buf_carray, vec_carray, list_carray, carray_ref,
carray_refset, carray_sub, carray_replace, carray_get_common,
carray_put_common, unum_carray, num_carray, put_carray,
fill_carray): Pass self name to carray_struct_checked.
(carray_blank, carray_buf, carray_cptr): Pass self name
ffi_type_struct_checked.
(carray_pun): Pass self name to carray_struct_checked and
ffi_type_struct_checked.
(make_union): Pass self name to ffi_type_struct_checked.
(union_members, union_get, union_put, union_in, union_out):
Pass self name to uni_struct_checked.
(make_zstruct, zero_fill, put_obj, get_obj, fill_obj): Pass
self-name to ffi_type_struct_checked.

* ffi.h (ffi_closure_get_fptr, union_get_ptr): Declarations
updated.

* filter.c (trie_add): Pass self-name to gethash_l.

* hash.c (make_similar_hash, copy_hash, hash_count,
get_hash_userdata, set_hash_userdata, hash_begin, hash_next,
hash_uni, hash_diff, hash_isec): Pass self name
to cobj_handle.
(gethash_c, gethash_e): Take self name parameter and pass down
to cobj_handle.
(gethash_f): Take self parameter and pass down to gethash_e.
(gethash, inhash, gethash_n, sethash, pushhash, remhash,
clearhash, hash_update_1): Pass self name to gethash_e or gethash_c.

* hash.h (gethash_c, gethash_e, gethash_f): Declarations
updated.
(gethash_l): Take self name, and pass down to gethash_c.

* lib.c (class_check): Take self name parameter and use in
type mismatch diagnostic.
(use_sym, unuse_sym, symbol_needs_prefix, find_symbol,
intern, unintern, intern_fallback, unique, in, sel,
obj_print_impl, populate_obj_hash, obj_hash_merge): Pass self
name to gethash_f or gethash_l.
(symbol_visible, obj_init): Pass situation-identifying string
to gethash_e.
(cobj_handle, cobj_ops): Take self name parameter and pass
down to class_check.

* lib.h (class_check, cobj_handle, cobj_ops): Declarations
updated.

* match.c (v_load): Pass self name to read_compiled_file and
read_eval_stream.

* parser.c (get_parser_impl): Take self name and pass to
cobj_handle.
(ensure_parser): Pass situation-identifying string to
gethash_c.
(parser_circ_def): Pass self-name to gethash_c.
(lisp_parser_impl): Pass self name to get_parser_impl and
class_check.
(lisp_parse, nread, iread): Pass self-name to lisp_parser_impl.
(read_file_common): Take self name parameter and pass down to
get_parser_impl.
(read_eval_stream, read_compiled_file): Take self name and
pass down to read_file_common.
(load_rcfile): Pass situation-identifying string to
read_eval_streem.
(get_visible_syms): Pass situation-identifying string to
gethash_c.
(parser_errors, parser_eof): Pass self name to cobj_handle.

* parser.h (read_eval_stream, read_compiled_file):
Declarations updated.

* parser.y (rlset): Pass self name to gethash_c.

* rand.c (make_random_state, random_state_get_vec,l
random_fixnum, random_float): Pass self name to cobj_handle.

* regex.c (regex_source, regex_print, regex_run): Pass
self-name to cobj_handle.
(regex_machine_init): Take self name param and pass to
cobj_handle.
(search_regex, match_regex, match_regex_right,
regex_prefix_match, read_until_match): Pass self-name to
regex_machine_init.

* stream.c (stdio_get_fd): Pass self name to cobj_handle.
(generic_get_line): Get COBJ operations via unsafe, diret
object access rather than cobj_ops.
(set_mode_props): Get object handle via unsafe, direct object
access.
(stream_fd, sock_family, sock_type, sock_peer, set_sock_peer,
get_string_from_stream, get_list_from_stream, stream_set_prop,
stream_get_prop, close_stream, get_error, get_error_str,
clear_error, get_line, get_char, get_byte, unget_char,
unget_byte, put_buf, fill_buf, put_string, put_char, put_byte,
flush_stream, seek_stream, truncate_stream, get_indent_mode,
test_set_indent_mode, set_indent_mode, get_indent, set_indent,
inc_indent, width_check, force_break, get_set_ctx, get_ctx):
Pass self name to cobj_ops.
(make_delegate_stream): Take self name parameter, pass down to
cobj_ops.
(record_adapter): Pass self name down to make_delegate_stream.
(format): Pass self name to class_check.

* struct.c (stype_handle): Pass self name to cobj_handle.
(make_struct_type): Pass self name to class_check.

* txr.c (read_eval_stream_noerr): Take self name parameter,
pass to read_eval_stream.
(txr_main): Pass istuation-identifying string to
read_compiled_file and read_eval_stream_noerr.

* unwind.c (revive_cont): Pass self-name to cobj_handle.

* vm.c (vm_desc_struct): Take self name parameter, pass to
cobj_handle.
(vm_desc_nlevels, vm_desc_nregs, vm_desc_bytecode,
vm_desc_datavec, vm_desc_symvec, vm_execute_toplevel,
vm_execute_closure, vm_closure_entry): Pass self name to
vm_desc_struct.
(vm_closure_struct): Take self name parameter, pass to
cobj_handle.
---
 stream.c | 165 +++++++++++++++++++++++++++++++++++++++++++--------------------
 1 file changed, 112 insertions(+), 53 deletions(-)

(limited to 'stream.c')

diff --git a/stream.c b/stream.c
index 1b6f831a..57245de1 100644
--- a/stream.c
+++ b/stream.c
@@ -747,14 +747,15 @@ static val stdio_clear_error(val stream)
 
 static val stdio_get_fd(val stream)
 {
+  val self = lit("stream-fd");
   struct stdio_handle *h = coerce(struct stdio_handle *,
-                                  cobj_handle(stream, stdio_stream_s));
+                                  cobj_handle(self, stream, stdio_stream_s));
   return h->f ? num(fileno(h->f)) : nil;
 }
 
 val generic_get_line(val stream)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  struct strm_ops *ops = coerce(struct strm_ops *, stream->co.ops);
   const size_t min_size = 512;
   size_t size = 0;
   size_t fill = 0;
@@ -1471,8 +1472,8 @@ val normalize_mode_no_bin(struct stdio_mode *m, val mode_str, struct stdio_mode
 val set_mode_props(const struct stdio_mode m, val stream)
 {
   if (m.interactive || m.linebuf || m.unbuf || m.buforder != -1) {
-    struct stdio_handle *h = coerce(struct stdio_handle *,
-                                    cobj_handle(stream, stdio_stream_s));
+    struct stdio_handle *h = coerce(struct stdio_handle *, stream->co.handle);
+
     if (h->f) {
       int size = m.buforder == -1 ? 0 : 1024 << m.buforder;
 
@@ -1561,32 +1562,42 @@ val make_sock_stream(FILE *f, val family, val type)
 
 val stream_fd(val stream)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("fileno");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->get_fd(stream);
 }
 
 #if HAVE_SOCKETS
 val sock_family(val stream)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("sock-family");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->get_sock_family(stream);
 }
 
 val sock_type(val stream)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("sock-type");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->get_sock_type(stream);
 }
 
 val sock_peer(val stream)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("sock-peer");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->get_sock_peer(stream);
 }
 
 val sock_set_peer(val stream, val peer)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("sock-set-peer");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->set_sock_peer(stream, peer);
 }
 #endif
@@ -2183,8 +2194,9 @@ val make_string_output_stream(void)
 
 val get_string_from_stream(val stream)
 {
+  val self = lit("get-string-from-stream");
   struct string_out *so = coerce(struct string_out *,
-                                    cobj_handle(stream, stream_s));
+                                 cobj_handle(self, stream, stream_s));
 
   if (stream->co.ops == &string_out_ops.cobj_ops) {
     val out = nil;
@@ -2300,8 +2312,9 @@ val make_strlist_output_stream(void)
 
 val get_list_from_stream(val stream)
 {
+  val self = lit("get-list-from-stream");
   struct strlist_out *s = coerce(struct strlist_out *,
-                                 cobj_handle(stream, stream_s));
+                                 cobj_handle(self, stream, stream_s));
 
   if (stream->co.ops == &strlist_out_ops.cobj_ops) {
     val stray = get_string_from_stream(s->strstream);
@@ -2665,11 +2678,11 @@ static val delegate_set_sock_peer(val stream, val peer)
 
 #endif
 
-static val make_delegate_stream(val orig_stream, size_t handle_size,
+static val make_delegate_stream(val self, val orig_stream, size_t handle_size,
                                 struct cobj_ops *ops)
 {
   struct strm_ops *orig_ops = coerce(struct strm_ops *,
-                                     cobj_ops(orig_stream, stream_s));
+                                     cobj_ops(self, orig_stream, stream_s));
   struct delegate_base *db = coerce(struct delegate_base *,
                                     chk_calloc(1, handle_size));
   val delegate_stream;
@@ -2729,7 +2742,8 @@ static struct strm_ops record_adapter_ops =
 
 val record_adapter(val regex, val stream, val include_match)
 {
-  val rec_adapter = make_delegate_stream(default_arg(stream, std_input),
+  val self = lit("record-adapter");
+  val rec_adapter = make_delegate_stream(self, default_arg(stream, std_input),
                                          sizeof (struct record_adapter_base),
                                          &record_adapter_ops.cobj_ops);
   struct record_adapter_base *rb = coerce(struct record_adapter_base *,
@@ -2747,13 +2761,17 @@ val streamp(val obj)
 
 val stream_set_prop(val stream, val ind, val prop)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("stream-set-prop");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->set_prop(stream, ind, prop);
 }
 
 val stream_get_prop(val stream, val ind)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("stream-get-prop");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->get_prop(stream, ind);
 }
 
@@ -2769,84 +2787,106 @@ val real_time_stream_p(val obj)
 
 val close_stream(val stream, val throw_on_error)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("close-stream");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->close(stream, throw_on_error);
 }
 
 val get_error(val stream)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("get-error");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->get_error(stream);
 }
 
 val get_error_str(val stream)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("get-error-str");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->get_error_str(stream);
 }
 
 val clear_error(val stream)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("clear-error");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->clear_error(stream);
 }
 
 val get_line(val stream_in)
 {
+  val self = lit("get-line");
   val stream = default_arg(stream_in, std_input);
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->get_line(stream);
 }
 
 val get_char(val stream_in)
 {
+  val self = lit("get-char");
   val stream = default_arg(stream_in, std_input);
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->get_char(stream);
 }
 
 val get_byte(val stream_in)
 {
+  val self = lit("get-byte");
   val stream = default_arg(stream_in, std_input);
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->get_byte(stream);
 }
 
 val unget_char(val ch, val stream_in)
 {
+  val self = lit("unget-char");
   val stream = default_arg(stream_in, std_input);
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   if (!is_chr(ch))
-    type_mismatch(lit("unget-char: ~s is not a character"), ch, nao);
+    type_mismatch(lit("~a: ~s is not a character"), self, ch, nao);
   return ops->unget_char(stream, ch);
 }
 
 val unget_byte(val byte, val stream_in)
 {
+  val self = lit("unget-byte");
   cnum b = c_num(byte);
   val stream = default_arg(stream_in, std_input);
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
 
   if (b < 0 || b > 255)
-    uw_throwf(file_error_s, lit("unget-byte on ~a: byte value ~a out of range"),
-              stream, byte, nao);
+    uw_throwf(file_error_s, lit("~a: stream ~s, byte value ~a out of range"),
+              self, stream, byte, nao);
 
   return ops->unget_byte(stream, b);
 }
 
 val put_buf(val buf, val pos_in, val stream_in)
 {
+  val self = lit("put-buf");
   val stream = default_arg(stream_in, std_output);
   cnum pos = c_num(default_arg(pos_in, zero));
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->put_buf(stream, buf, pos);
 }
 
 val fill_buf(val buf, val pos_in, val stream_in)
 {
+  val self = lit("fill-buf");
   val stream = default_arg(stream_in, std_input);
   cnum pos = c_num(default_arg(pos_in, zero));
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->fill_buf(stream, buf, pos);
 }
 
@@ -3461,11 +3501,12 @@ val vformat_to_string(val fmtstr, va_list vl)
 
 val format(val stream, val str, ...)
 {
+  val self = lit("format");
   uses_or2;
   val st = if3(stream == t,
                std_output,
                or2(stream, make_string_output_stream()));
-  class_check(st, stream_s);
+  class_check(self, st, stream_s);
 
   {
     va_list vl;
@@ -3492,11 +3533,13 @@ static val put_indent(val stream, struct strm_ops *ops, cnum chars)
 
 val put_string(val string, val stream_in)
 {
+  val self = lit("put-string");
   if (lazy_stringp(string)) {
     return lazy_str_put(string, stream_in);
   } else {
     val stream = default_arg(stream_in, std_output);
-    struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+    struct strm_ops *ops = coerce(struct strm_ops *,
+                                  cobj_ops(self, stream, stream_s));
     struct strm_base *s = coerce(struct strm_base *, stream->co.handle);
     cnum col = s->column;
 
@@ -3532,8 +3575,10 @@ val put_string(val string, val stream_in)
 
 val put_char(val ch, val stream_in)
 {
+  val self = lit("put-char");
   val stream = default_arg(stream_in, std_output);
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   struct strm_base *s = coerce(struct strm_base *, stream->co.handle);
   wint_t cch = c_chr(ch);
 
@@ -3568,13 +3613,15 @@ val put_char(val ch, val stream_in)
 
 val put_byte(val byte, val stream_in)
 {
+  val self = lit("put-byte");
   val stream = default_arg(stream_in, std_output);
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   cnum b = c_num(byte);
 
   if (b < 0 || b > 255)
-    uw_throwf(file_error_s, lit("put-byte on ~a: byte value ~a out of range"),
-              stream, byte, nao);
+    uw_throwf(file_error_s, lit("~a: stream ~s: byte value ~a out of range"),
+              self, stream, byte, nao);
 
   return ops->put_byte(stream, b);
 }
@@ -3604,14 +3651,18 @@ val put_lines(val lines, val stream)
 
 val flush_stream(val stream_in)
 {
+  val self = lit("flush-stream");
   val stream = default_arg(stream_in, std_output);
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   return ops->flush(stream);
 }
 
 val seek_stream(val stream, val offset, val whence)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("seek-stream");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   enum strm_whence w;
 
   if (whence == from_start_k)
@@ -3621,15 +3672,17 @@ val seek_stream(val stream, val offset, val whence)
   else if (whence == from_end_k)
     w = strm_end;
   else
-    uw_throwf(file_error_s, lit("seek: ~a is not a valid whence argument"),
-              whence, nao);
+    uw_throwf(file_error_s, lit("~a: ~s is not a valid whence argument"),
+              self, whence, nao);
 
   return ops->seek(stream, offset, w);
 }
 
 val truncate_stream(val stream, val len)
 {
-  struct strm_ops *ops = coerce(struct strm_ops *, cobj_ops(stream, stream_s));
+  val self = lit("truncate-stream");
+  struct strm_ops *ops = coerce(struct strm_ops *,
+                                cobj_ops(self, stream, stream_s));
   if (missingp(len))
     len = ops->seek(stream, zero, strm_cur);
   return ops->truncate(stream, len);
@@ -3637,15 +3690,17 @@ val truncate_stream(val stream, val len)
 
 val get_indent_mode(val stream)
 {
+  val self = lit("get-indent-mode");
   struct strm_base *s = coerce(struct strm_base *,
-                               cobj_handle(stream, stream_s));
+                               cobj_handle(self, stream, stream_s));
   return num_fast(s->indent_mode);
 }
 
 val test_set_indent_mode(val stream, val compare, val mode)
 {
+  val self = lit("test-set-indent-mode");
   struct strm_base *s = coerce(struct strm_base *,
-                               cobj_handle(stream, stream_s));
+                               cobj_handle(self, stream, stream_s));
   val oldval = num_fast(s->indent_mode);
   if (oldval == compare)
     s->indent_mode = convert(enum indent_mode, c_num(mode));
@@ -3654,8 +3709,9 @@ val test_set_indent_mode(val stream, val compare, val mode)
 
 val set_indent_mode(val stream, val mode)
 {
+  val self = lit("set-indent-mode");
   struct strm_base *s = coerce(struct strm_base *,
-                               cobj_handle(stream, stream_s));
+                               cobj_handle(self, stream, stream_s));
   val oldval = num_fast(s->indent_mode);
   s->indent_mode = convert(enum indent_mode, c_num(mode));
   return oldval;
@@ -3663,15 +3719,17 @@ val set_indent_mode(val stream, val mode)
 
 val get_indent(val stream)
 {
+  val self = lit("get-indent");
   struct strm_base *s = coerce(struct strm_base *,
-                               cobj_handle(stream, stream_s));
+                               cobj_handle(self, stream, stream_s));
   return num(s->indent_chars);
 }
 
 val set_indent(val stream, val indent)
 {
+  val self = lit("set-indent");
   struct strm_base *s = coerce(struct strm_base *,
-                               cobj_handle(stream, stream_s));
+                               cobj_handle(self, stream, stream_s));
   val oldval = num(s->indent_chars);
   s->indent_chars = c_num(indent);
   if (s->indent_chars < 0)
@@ -3681,8 +3739,9 @@ val set_indent(val stream, val indent)
 
 val inc_indent(val stream, val delta)
 {
+  val self = lit("inc-indent");
   struct strm_base *s = coerce(struct strm_base *,
-                               cobj_handle(stream, stream_s));
+                               cobj_handle(self, stream, stream_s));
   val oldval = num(s->indent_chars);
   val col = num(s->column);
   s->indent_chars = c_num(plus(delta, col));
@@ -3693,8 +3752,9 @@ val inc_indent(val stream, val delta)
 
 val width_check(val stream, val alt)
 {
+  val self = lit("width-check");
   struct strm_base *s = coerce(struct strm_base *,
-                               cobj_handle(stream, stream_s));
+                               cobj_handle(self, stream, stream_s));
 
   if ((s->indent_mode == indent_code &&
        s->column >= s->indent_chars + s->code_width) ||
@@ -3714,16 +3774,16 @@ val width_check(val stream, val alt)
 
 val force_break(val stream)
 {
+  val self = lit("force-break");
   struct strm_base *s = coerce(struct strm_base *,
-                               cobj_handle(stream, stream_s));
+                               cobj_handle(self, stream, stream_s));
   s->force_break = 1;
   return stream;
 }
 
 struct strm_ctx *get_set_ctx(val stream, struct strm_ctx *ctx)
 {
-  struct strm_base *s = coerce(struct strm_base *,
-                               cobj_handle(stream, stream_s));
+  struct strm_base *s = coerce(struct strm_base *, stream->co.handle);
   struct strm_ctx *ret = s->ctx;
   s->ctx = ctx;
   return ret;
@@ -3731,8 +3791,7 @@ struct strm_ctx *get_set_ctx(val stream, struct strm_ctx *ctx)
 
 struct strm_ctx *get_ctx(val stream)
 {
-  struct strm_base *s = coerce(struct strm_base *,
-                               cobj_handle(stream, stream_s));
+  struct strm_base *s = coerce(struct strm_base *, stream->co.handle);
   return s->ctx;
 }
 
-- 
cgit v1.2.3