From 4016b57938b5d1491e41625eae67c4ed2d66193e Mon Sep 17 00:00:00 2001
From: Kaz Kylheku <kaz@kylheku.com>
Date: Sun, 27 Nov 2016 09:14:01 -0800
Subject: Warn about unbound functions.

* eval.c (do_expand): If a compound form doesn't expand into
anything, then let us check whether it calls an unbound
function, and issue a warning.

* share/txr/stdlib/place.tl (sys:pl-expand): Move function
definition ahead of first use to suppress unbound function
warning. Eventually we will have a relaxed model of deferred
warning about this.
(sys:placelet-1): Suppress warnings around call to sys:expand
because we are expanding a body into which we inserted
function calls without inserting their definitions.
---
 share/txr/stdlib/place.tl | 41 +++++++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 20 deletions(-)

(limited to 'share')

diff --git a/share/txr/stdlib/place.tl b/share/txr/stdlib/place.tl
index b18fddbf..76ca95e2 100644
--- a/share/txr/stdlib/place.tl
+++ b/share/txr/stdlib/place.tl
@@ -88,6 +88,22 @@
                      (makunbound ',',place-expr))))
        ,*op-body))
 
+  (defun sys:pl-expand (unex-place env)
+    (while t
+      (let ((place unex-place))
+        (let ((pm-expander [*place-macro* (if (consp unex-place)
+                                            (car unex-place))]))
+          (when pm-expander
+            (sys:setq place (sys:set-macro-ancestor
+                              [pm-expander unex-place]
+                              unex-place))))
+        (sys:setq place (macroexpand-1 place env))
+        (when (or (eq place unex-place)
+                  (null place)
+                  (and (atom place) (not (symbolp place))))
+          (return place))
+        (sys:setq unex-place place))))
+
   (defun place-form-p (unex-place env)
     (let ((place (sys:pl-expand unex-place env)))
       (or (bindable place)
@@ -146,22 +162,6 @@
   ^(let ,(zip syms (repeat '((gensym)))) ,*body))
 
 (macro-time
-  (defun sys:pl-expand (unex-place env)
-    (while t
-      (let ((place unex-place))
-        (let ((pm-expander [*place-macro* (if (consp unex-place)
-                                            (car unex-place))]))
-          (when pm-expander
-            (sys:setq place (sys:set-macro-ancestor
-                              [pm-expander unex-place]
-                              unex-place))))
-        (sys:setq place (macroexpand-1 place env))
-        (when (or (eq place unex-place)
-                  (null place)
-                  (and (atom place) (not (symbolp place))))
-          (return place))
-        (sys:setq unex-place place))))
-
   (defun sys:cp-origin (to-tree from-form : circ-check)
     (unless (memq to-tree circ-check)
       (tree-case to-tree
@@ -885,10 +885,11 @@
                       ,tmp-body)))
         (call-update-expander pl-getter pl-setter place env
           ^(macrolet ((,tmp-place () ^(,',pl-getter)))
-             ,(sys:expand
-                ^(symacrolet ((,sym (,tmp-place)))
-                   ,*body)
-                env))))
+             ,(ignwarn
+                (sys:expand
+                  ^(symacrolet ((,sym (,tmp-place)))
+                     ,*body)
+                  env)))))
       (remhash *place-update-expander* tmp-place))))
 
 (defmacro placelet* (sym-place-pairs . body)
-- 
cgit v1.2.3