Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | android, cygwin: do not try to test crypt. | Kaz Kylheku | 2022-12-30 | 1 | -0/+3 |
| | | | | | * tests/018/crypt.tl: Exit with successful termination status on Android or Cygwin. | ||||
* | crypt: fix for platforms that lack crypt_r. | Kaz Kylheku | 2022-12-30 | 1 | -1/+1 |
| | | | | | | | | | | | | * sysif.c (crypt_wrap): Don't call free(cd) on platforms where we don't have crypt_r and have not defined the cd variable. * test/018/crypt.tl: Move the (crypt "a" "b") test case to be GNU/Linux-only. On Solaris, it yields a valid-looking hash instead of failing. That hash will not validate the password though; i.e. (crypt "a" (crypt "a" "b")) is not equal to (crypt "a" "b"). | ||||
* | crypt: remove dubious validator. | Kaz Kylheku | 2022-10-31 | 1 | -0/+18 |
The validate_salt function was introduced in commit c3a0ceb2cea1a9d43f2baf5a2e63d0d712c8df19, February 2020. I cannot reproduce the internal crash in crypt which it alleges, and I neglected to mention the bad inputs in the commit or add tests. I'm not able to reproduce the alleged behavior in spite of trying all sorts of bad inputs; and looking at the crypt source in glibc, I don't see any obvious problem. And so, on this Halowe'en, we exorcise the ghost that has been haunting the crypt. * sysif.c (salt_char_p, validate_salt): Static functions removed. (crypt_wrap): Don't call validate_salt, and so cwsalt need not be tested for null. * tests/018/crypt.tl: New file. * txr.1: Mention that crypt_r is used if available, which avoids static storage. |