parser: security: UTF-8 and NUL handling in literals.

A null byte in regex and string literals is being processed as
a #\nul instead of correctly turning into #\pnul. Bad UTF-8 is
not being rejected.

* parser.l (REGCHAR, LITCHAR): Use utf8_from_buffer to
properly convert yytext using its true length, rather than
utf8_from which assumes a null-terminated string. Thus
null bytes (including the case of a yytext being single NUL)
are handled properly. Check that the result is exactly one
character (null-terminated buffer, two characters wide).

* utf8.c (utf8_from): Unused function removed.

* utf8.h (utf8_from): Declaration removed.

1 files changed, 0 insertions, 1 deletions

diff --git a/utf8.h b/utf8.h
index a60fe944..a007ac68 100644
--- a/utf8.h
+++ b/utf8.h
@@ -26,7 +26,6 @@
  */
 
 size_t utf8_from_buf(wchar_t *, const unsigned char *, size_t nbytes);
-size_t utf8_from(wchar_t *, const char *);
 size_t utf8_to_buf(unsigned char *dst, const wchar_t *wsrc, int null_term);
 size_t utf8_to(char *, const wchar_t *);
 wchar_t *utf8_dup_from(const char *);