Casts have crept into the code not wrapped by macros.

It is against TXR coding conventions to use the C cast
notation. The usage creeps into the code. To find instances of
this, we must compile using GNU g++, and add -Wold-style-cast
via EXTRA_FLAGS.

* eval.c (prof_call): Use macro instead of cast.

* ffi.c (pad_retval, ffi_varray_alloc, make_ffi_type_union,
carray_dup, carray_replace, uint_carray, int_carray,
put_carray, fill_carray): Likewise.

* itypes.c (c_i64, c_u64): Likewise.

* lib.c (cyr, chk_xalloc,  spilt_str_keep, vector,
cobj_register): Likewise.

* linenoise.c (record_undo): Likewise. Also, drop one
superfluous cast: wstrdup_fn returns wchar_t *.
(flash, edit_insert, edit_insert_str): Use macro instead of cast.

* mpi/mpi.c (s_mp_ispow2d): Likewise.

* parser.c (lino_getch): Likewise.

* rand.c (make_random_state, random_buf): Likewise.

* stream.c (generic_get_line, do_parse_mode): Likewise.

* struct.c (get_duplicate_supers, call_initfun_chain,
call_postinitfun_chain): Likewise.

* sysif.c (c_time): Likewise.

* tree.c (tr_insert): Likewise.

1 files changed, 3 insertions, 3 deletions

diff --git a/stream.c b/stream.c
index ebbb7e19..75d46537 100644
--- a/stream.c
+++ b/stream.c
@@ -843,7 +843,7 @@ val generic_get_line(val stream)
 
   for (;;) {
     val chr = ops->get_char(stream);
-    wint_t ch = chr ? (wint_t) c_chr(chr) : WEOF;
+    wint_t ch = chr ? convert(wint_t, c_chr(chr)) : WEOF;
 
     if (ch == WEOF && buf == 0)
       break;
@@ -1530,13 +1530,13 @@ static struct stdio_mode do_parse_mode(val mode_str, struct stdio_mode m_dfl,
       }
 
       if (ms[1] != '(') {
-        if (!isdigit((unsigned char) ms[1]) || !ms[2]) {
+        if (!isdigit(convert(unsigned char, ms[1])) || !ms[2]) {
           m.malformed = 1;
           return m;
         }
 
         m.redir[nredir][0] = ms[1] - '0';
-        if (isdigit((unsigned char) ms[2])) {
+        if (isdigit(convert(unsigned char, ms[2]))) {
           m.redir[nredir][1] = ms[2] - '0';
         } else switch (ms[2]) {
         case 'n': case 'x':