diff options
author | Kaz Kylheku <kaz@kylheku.com> | 2021-06-24 07:47:48 -0700 |
---|---|---|
committer | Kaz Kylheku <kaz@kylheku.com> | 2021-06-24 07:47:48 -0700 |
commit | 9ec5e89c859b70b03a65ff773f8f85eddc277f71 (patch) | |
tree | 1b5164d576178af56d9b28fbed3aed3ec54f130f /parser.l | |
parent | c45cb488586b0f8c54120d9eacb6491df017609b (diff) | |
download | txr-9ec5e89c859b70b03a65ff773f8f85eddc277f71.tar.gz txr-9ec5e89c859b70b03a65ff773f8f85eddc277f71.tar.bz2 txr-9ec5e89c859b70b03a65ff773f8f85eddc277f71.zip |
parser: no string allocation when scanning floats.
Each time the scanner processes a floating-point token,
it allocates a string object, just so it can call flo_str.
The object is then garbage. Let's stop doing that.
* lib.c (flo_str_utf8): New function, closely based on flo_str.
Takes a char * string.
* lib.h (flo_str_utf8): Declared.
* parser.l (out_of_range_float): Take the token as a const
char * string instead of a Lisp string, so we can just pass
yytext to this function.
(grammar): Use flo_str_utf8 instead flo_str, and pass yytext
to out_of_range_float.
* lex.yy.c.shipped: Updated.
Diffstat (limited to 'parser.l')
-rw-r--r-- | parser.l | 25 |
1 files changed, 10 insertions, 15 deletions
@@ -130,10 +130,10 @@ static void yyerrprepf(scanner_t *scanner, val fmt, ...) } } -static void out_of_range_float(scanner_t *scanner, val tok) +static void out_of_range_float(scanner_t *scanner, const char *tok) { yyerrorf(scanner, lit("out-of-range floating-point literal: ~a"), - tok, nao); + string_utf8(tok), nao); } static wchar_t char_esc(int letter) @@ -343,15 +343,13 @@ NJPUNC [^(){},:\[\]"~*^ \t\n] } <SPECIAL,NESTED,BRACED>{WS}{FLO} { - val str = string_own(utf8_dup_from(yytext)); - if (yy_top_state(yyscanner) == INITIAL || yy_top_state(yyscanner) == QSILIT || yy_top_state(yyscanner) == QWLIT) yy_pop_state(yyscanner); - if ((yylval->val = flo_str(str)) == nil) - out_of_range_float(yyg, str); + if ((yylval->val = flo_str_utf8(yytext)) == nil) + out_of_range_float(yyg, yytext); return NUMBER; } @@ -368,22 +366,20 @@ NJPUNC [^(){},:\[\]"~*^ \t\n] || yy_top_state(yyscanner) == QWLIT) yy_pop_state(yyscanner); - if ((yylval->val = flo_str(str)) == nil) - out_of_range_float(yyg, str); + if ((yylval->val = flo_str_utf8(yytext)) == nil) + out_of_range_float(yyg, yytext); return NUMBER; } <SPECIAL,QSPECIAL,NESTED,BRACED>{FLODOT}/[^.] { - val str = string_own(utf8_dup_from(yytext)); - if (yy_top_state(yyscanner) == INITIAL || yy_top_state(yyscanner) == QSILIT || yy_top_state(yyscanner) == QWLIT) yy_pop_state(yyscanner); - if ((yylval->val = flo_str(str)) == nil) - out_of_range_float(yyg, str); + if ((yylval->val = flo_str_utf8(yytext)) == nil) + out_of_range_float(yyg, yytext); return NUMBER; } @@ -1178,9 +1174,8 @@ NJPUNC [^(){},:\[\]"~*^ \t\n] } <JSON>{JNUM} { - val str = string_own(utf8_dup_from(yytext)); - if ((yylval->val = flo_str(str)) == nil) - out_of_range_float(yyg, str); + if ((yylval->val = flo_str_utf8(yytext)) == nil) + out_of_range_float(yyg, yytext); return NUMBER; } |