trace: implement redefinition checks.

The tracing module should warn when traced functions or
methods are being redefined, and stop tracing the original
methods.

* eval.c (trace_check): New function. Calls
sys:trace-redefined-check if the trace module has been
loaded, otherwise does nothing.
(op_defun, op_defmacro): Call trace_check to have a warning
issued for a redefined traced function or macro.

* eval.h (trace_check): Declared.

* lisplib.c (trace_loaded): New global variable.
(trace_instantiate): Flip trace_loaded to t.

* lisplib.h (trace_loaded): Declared.

* share/txr/stdlib/trace.tl (sys:trace-redefine-check): New
function. Checks two situations: traced function or method
is redefined (neither old nor new is traced any longer),
and traced method is overridden (base method continues to be
traced, override is not traced).

* struct.c (static_slot_ensure): Do a trace check here,
taking care of defmeth.

1 files changed, 2 insertions, 0 deletions

diff --git a/lisplib.c b/lisplib.c
index 9d708a1c..cbe2de5d 100644
--- a/lisplib.c
+++ b/lisplib.c
@@ -44,6 +44,7 @@
 
 val dl_table;
 int opt_dbg_autoload;
+val trace_loaded;
 
 void set_dlt_entries(val dlt, val *name, val fun)
 {
@@ -392,6 +393,7 @@ static val trace_instantiate(val set_fun)
 {
   funcall1(set_fun, nil);
   load(format(nil, lit("~atrace.tl"), stdlib_path, nao));
+  trace_loaded = t;
   return nil;
 }