diff options
author | Kaz Kylheku <kaz@kylheku.com> | 2020-04-05 19:31:04 -0700 |
---|---|---|
committer | Kaz Kylheku <kaz@kylheku.com> | 2020-04-05 19:31:04 -0700 |
commit | 858ce927fc30d080793fffe42b0ce6fcddfbb3c5 (patch) | |
tree | 4be9082f8d3243ff23414aaaefa15db7a3708c80 /lib.c | |
parent | 579a30ef3f8a6656c4db38d43c34f4dc3403af33 (diff) | |
download | txr-858ce927fc30d080793fffe42b0ce6fcddfbb3c5.tar.gz txr-858ce927fc30d080793fffe42b0ce6fcddfbb3c5.tar.bz2 txr-858ce927fc30d080793fffe42b0ce6fcddfbb3c5.zip |
warning cleanup: remove unused parameters.
This is the second round of an effort to enable GCC's -Wextra
option. All function parameters that are unused and
are removable are removed. They are eliminated from the
function defintions, declarations, callers, and any related
function pointer variables or structure members.
* arith.c (nary_simple_op): Remove unused self parameter.
See lib.c: maxv, minv.
* chksum.c (crc32_buf, crc32_str): Remove unused self
parameter.
(crc32): Don't pass self to the above functions.
* eval.c (copy_env_handler, copy_bh_env_handler): Remove
unused parent parameter. See unwind.c.
(supplement_op_syms): Remove unused max parameter.
(me_op): Don't pass max to supplement_op_syms.
* lib.c (seq_iter_rewind): Remove unused self parameter.
(lazy_flatten_func): Remove unused env parameter.
(lazy_flatten): Use func_n1 to create non-environment-carrying
funtion out of lazy_flatten_func.
(maxv, minv): Don't pass self parameter to nary_simple_op.
(middle_pivot): Remove unused lessfun param.
(quicksort): Don't pass lessfun to middle_pivot.
(diff, isec): Don't pass self to seq_iter_rewind.
* lib.h (seq_iter_rewind, nary_simple_op): Declarations
updated.
* struct.c (get_super_slots): Remove unused self parameteer.
(make_struct_type): Don't pass self to get_super_slots.
* sysif.c (flock_unpack): Remove unused self parameter.
(fcntl_wrap): Don't pass self to flock_unpack.
* unwind.c (uw_push_cont_copy): Remove parent parameter from
function pointer parameter. See eval.c: copy_env_handler.
(call_copy_handlers): Remove parent parameter and don't
pass that argument to the indirect call via pointer
to the copy handler function.
(revive_cont, capture_cont): Don't pass 0 value to
removed parent parameter of call_copy_handlers.
* unwind.h (struct uw_cont_copy): Function pointer member copy
loses parent parameter.
(uw_push_cont_copy): Declaration updated.
Diffstat (limited to 'lib.c')
-rw-r--r-- | lib.c | 18 |
1 files changed, 9 insertions, 9 deletions
@@ -396,7 +396,7 @@ val seq_geti(seq_iter_t *it) return v; } -void seq_iter_rewind(val self, seq_iter_t *it) +void seq_iter_rewind(seq_iter_t *it) { switch (it->inf.kind) { case SEQ_NIL: @@ -2287,7 +2287,7 @@ static val lazy_flatten_scan(val list, val *escape) } } -static val lazy_flatten_func(val env, val lcons) +static val lazy_flatten_func(val lcons) { us_cons_bind (list, escape, lcons); val atom = car(list); @@ -2314,7 +2314,7 @@ val lazy_flatten(val list) if (!next) return nil; - return make_lazy_cons_car_cdr(func_f1(nil, lazy_flatten_func), + return make_lazy_cons_car_cdr(func_n1(lazy_flatten_func), next, escape); } } @@ -3436,12 +3436,12 @@ val min2(val a, val b) val maxv(val first, struct args *rest) { - return nary_simple_op(lit("max"), max2, rest, first); + return nary_simple_op(max2, rest, first); } val minv(val first, struct args *rest) { - return nary_simple_op(lit("min"), min2, rest, first); + return nary_simple_op(min2, rest, first); } val maxl(val first, val rest) @@ -8795,7 +8795,7 @@ static cnum med_of_three(val vec, val lessfun, val keyfun, cnum from, cnum to, } } -static cnum middle_pivot(val vec, val lessfun, val keyfun, cnum from, cnum to, +static cnum middle_pivot(val vec, val keyfun, cnum from, cnum to, val *pkval) { cnum pivot = from + (to - from) / 2; @@ -8811,7 +8811,7 @@ static void quicksort(val vec, val lessfun, val keyfun, cnum from, cnum to) cnum i, j; cnum pivot = if3(to - from > 15, med_of_three(vec, lessfun, keyfun, from, to, &pkval), - middle_pivot(vec, lessfun, keyfun, from, to, &pkval)); + middle_pivot(vec, keyfun, from, to, &pkval)); swap(vec, num_fast(pivot), num_fast(to - 1)); @@ -10159,7 +10159,7 @@ val diff(val seq1, val seq2, val testfun, val keyfun) val el2; int found = 0; - seq_iter_rewind(self, &si2); + seq_iter_rewind(&si2); while (seq_get(&si2, &el2)) { val el2_key = funcall1(keyfun, el2); @@ -10265,7 +10265,7 @@ val isec(val seq1, val seq2, val testfun, val keyfun) val el1_key = funcall1(keyfun, el1); val el2; - seq_iter_rewind(self, &si2); + seq_iter_rewind(&si2); while (seq_get(&si2, &el2)) { val el2_key = funcall1(keyfun, el2); |