itypes: remove silly itypes_little_endian.

Curiously, the itypes_little_endian variable was introduced in
April 2017, in a the first commit implementing buffers. The
variable was initialized, but never referenced.  About a month
after that, I introduced HAVE_LITTLE_ENDIAN config.h macro,
which is always present and defined as 0 or 1. This was used
right away in the implementation of FFI bitfields, and later
on in other FFI work.  In spite of HAVE_LITTLE_ENDIAN, almost
exactly a year after itypes_little_endian was introduced, I
mistakenly put that variable to use instead of recognizing it
as superfluous and removing it in favor of using
HAVE_LITTLE_ENDIAN. That is what I'm doing now.

* itypes.c (itypes_little_endian): Variable removed.
(itypes_init): Function removed, since its only job is to
initialize this variable.

* itypesl.h (itypes_little_endian, itypes_init): Declarations
removed.

* lib.c (init): Call to itypes_init removed.

* parser.c (read_file_common): Instead of
itypes_little_indian, use HAVE_LITTLE_ENDIAN, which
the configuration script always exists and is defined
as 0 or 1.

1 files changed, 0 insertions, 1 deletions

diff --git a/lib.c b/lib.c
index 486ceee8..c2180abb 100644
--- a/lib.c
+++ b/lib.c
@@ -13086,7 +13086,6 @@ void init(val *stack_bottom)
   hash_init();
   struct_init();
   tree_init();
-  itypes_init();
   buf_init();
   ffi_init();
   sysif_init();