Strengthen against resource leaks upon exceptions.

* glob.c (glob_wrap): Perform argument conversions
that might throw before allocating UTF-8 string.

* parser.y (text): In the action for SPACE, the lexeme
is not needed so free($1) right away. If regex_compile
were to throw an exception, that lexeme will leak.

* socket.c (getaddrinfo_wrap): Harden against leakage of
node_u8 and service_u8 strings with an unwind block.
For instance, the hints structure could contain
bad values which cause addrinfo_in to throw.

* stream.c (make_string_byte_input_stream): Perform
possibly throwing argument conversions before allocating
resources.

* sysif.c (mkdir_wrap, mknod_wrap, chmod_wrap, symlink_wrap,
link_wrap, setenv_wrap, crypt_wrap): Likewise.

* syslog.c (openlog_wrap, syslog_wrapv): Likewise.

1 files changed, 1 insertions, 1 deletions

diff --git a/glob.c b/glob.c
index 09151375..c5914b2a 100644
--- a/glob.c
+++ b/glob.c
@@ -66,9 +66,9 @@ static int errfunc_thunk(const char *errpath, int errcode)
 
 val glob_wrap(val pattern, val flags, val errfunc)
 {
+  cnum c_flags = c_num(default_arg(flags, zero));
   char *pat_u8 = utf8_dup_to(c_str(pattern));
   glob_t gl;
-  cnum c_flags = c_num(default_arg(flags, zero));
 
   if (s_errfunc) {
     free(pat_u8);