diff options
| author | Kaz Kylheku <kaz@kylheku.com> | 2011-11-18 13:27:18 -0800 |
|---|---|---|
| committer | Kaz Kylheku <kaz@kylheku.com> | 2011-11-18 13:27:18 -0800 |
| commit | 469c98066160e682eda0fd2ba7a189e388ab9257 (patch) | |
| tree | 38fca8299308a1d4e3ed1f83a8b0048bc0d05999 /gc.c | |
| parent | 6d2bc0b88c6f0060bce5c79ee5879cf4ce77a35f (diff) | |
| download | txr-469c98066160e682eda0fd2ba7a189e388ab9257.tar.gz txr-469c98066160e682eda0fd2ba7a189e388ab9257.tar.bz2 txr-469c98066160e682eda0fd2ba7a189e388ab9257.zip | |
* gc.c (mark_mem_region): Use the Valgrind API only to mark
the type field as accessible, not the whole object that
we are checking. Marking the whole object accessible hides
uninitialized field bugs!
* lib.c: And found a bug already: lazy_str was not completely
initializing all of the object fields (ls.prefix, ls.list)
before invoking memory allocating operations, making it
possible for the garbage collector to encounter uninitialized
object areas.
Diffstat (limited to 'gc.c')
| -rw-r--r-- | gc.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -331,7 +331,7 @@ static void mark_mem_region(val *low, val *high) if (in_heap(maybe_obj)) { #ifdef HAVE_VALGRIND if (opt_vg_debug) - VALGRIND_MAKE_MEM_DEFINED(maybe_obj, sizeof *maybe_obj); + VALGRIND_MAKE_MEM_DEFINED(&maybe_obj->t.type, sizeof maybe_obj->t.type); #endif type_t t = maybe_obj->t.type; if ((t & FREE) == 0) { |