compile/eval: more standard formatting for diags.

This patch eliminates parentheses from the error messages,
as well as a leading ./ being added to relative paths.
The word "warning: " is moved into the error message, so that
it does not appear before the location.

Example, when doing (compile-file "path/to/foo.tl").

Before patch:

  warning: (./path/to/foo.tl:37): unbound function foo

After:

  path/to/foo.tl:37: warning: unbound function foo

Now when I compile out of Vim, it nicely jumps to errors in
Lisp code.

* eval.c (eval_exception): Drop parentheses from error
location, add colon.
(eval_warn): Prepend "warning: " to format string.
(eval_defr_warn): Drop parentheses from location, and
prepend "warning: " to format string.

* parser.c (repl-warning): Drop "warning:" prefix.

* share/txr/stdlib/compiler.tl (open-compile-streams): Do not
do parent substitution for relative paths if the parent path
is the empty string "", to avoid inserting ./ onto relative
paths in that case.

* share/txr/stdlib/error.tl (sys:loc): Drop parentheses and
space from location.
(compile-error) Separate location with colon and space.
(compile-warning, compile-defr-warning): Likewise and add
"warning: " prefix.

* unwind.c (uw_rthrow): Drop "warning: " prefix.
(uw_warningf): Add "warning: " prefix.
(uw_dump_deferred_warnings): Drop "warning: " prefix.

1 files changed, 4 insertions, 4 deletions

diff --git a/eval.c b/eval.c
index 1b603ce1..8fb645fc 100644
--- a/eval.c
+++ b/eval.c
@@ -294,7 +294,7 @@ static void eval_exception(val sym, val ctx, val fmt, va_list vl)
                 source_loc_str(last_form_evaled, nil));
 
   if (loc)
-    format(stream, lit("(~a) "), loc, nao);
+    format(stream, lit("~a: "), loc, nao);
 
   (void) vformat(stream, fmt, vl);
 
@@ -319,7 +319,7 @@ static val eval_warn(val ctx, val fmt, ...)
   uw_catch_begin (cons(continue_s, nil), exsym, exvals);
 
   va_start (vl, fmt);
-  eval_exception(warning_s, ctx, fmt, vl);
+  eval_exception(warning_s, ctx, scat2(lit("warning: "), fmt), vl);
   va_end (vl);
 
   uw_catch(exsym, exvals) { (void) exsym; (void) exvals; }
@@ -347,9 +347,9 @@ static val eval_defr_warn(val ctx, val tag, val fmt, ...)
                   source_loc_str(last_form_evaled, nil));
 
     if (loc)
-      format(stream, lit("(~a) "), loc, nao);
+      format(stream, lit("~a: "), loc, nao);
 
-    (void) vformat(stream, fmt, vl);
+    (void) vformat(stream, scat2(lit("warning: "), fmt), vl);
 
     uw_rthrow(defr_warning_s,
               cons(get_string_from_stream(stream), cons(tag, nil)));