From 94dc73adc55952e4e2a48463cab0bc4ec6a2c47e Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Mon, 14 Aug 2006 11:32:11 +0000 Subject: * security.cc (subauth): Initialize user_token to NULL. Add comment. --- winsup/cygwin/security.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'winsup/cygwin/security.cc') diff --git a/winsup/cygwin/security.cc b/winsup/cygwin/security.cc index d435f3072..618a57ef7 100644 --- a/winsup/cygwin/security.cc +++ b/winsup/cygwin/security.cc @@ -1009,7 +1009,10 @@ subauth (struct passwd *pw) QUOTA_LIMITS quota; char nt_domain[INTERNET_MAX_HOST_NAME_LENGTH + 1]; char nt_user[UNLEN + 1]; - HANDLE user_token = INVALID_HANDLE_VALUE; + /* Changed from INVALID_HANDLE_VALUE to NULL. A failed LsaLogonUser + sets the token to NULL anyway, so starting with NULL simplifies + the below test before calling CloseHandle. */ + HANDLE user_token = NULL; HANDLE primary_token = INVALID_HANDLE_VALUE; push_self_privilege (SE_TCB_PRIV, true); @@ -1076,7 +1079,7 @@ subauth (struct passwd *pw) out: pop_self_privilege (); - if (user_token != INVALID_HANDLE_VALUE) + if (user_token) CloseHandle (user_token); return primary_token; } -- cgit v1.2.3