From 1f8b30497dba80363a1e10af5dd7366156456a0e Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Mon, 4 Oct 2004 19:44:05 +0000 Subject: * bsd_mutex.cc (_msleep): Simplify event creation. Revert change from 2004-08-24. It should be unnecessary now. * msg.cc (client_request_msg::serve): Release process critical section as early as possible. * sem.cc (client_request_sem::serve): Ditto. * shm.cc (client_request_shm::serve): Ditto. * process.cc: Use hold and release method calls instead of EnterCriticalSection/LeaveCriticalSection calls throughout. * process.h (_hold): Rename from hold. Take filename and linenumber parameter for logging. Define matching hold macro. (release): Ditto. --- winsup/cygserver/msg.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'winsup/cygserver/msg.cc') diff --git a/winsup/cygserver/msg.cc b/winsup/cygserver/msg.cc index 1e086ed06..87df87310 100644 --- a/winsup/cygserver/msg.cc +++ b/winsup/cygserver/msg.cc @@ -72,6 +72,7 @@ client_request_msg::serve (transport_layer_base *const conn, } if (!adjust_identity_info (&_parameters.in.ipcblk)) { + client->release (); conn->revert_to_self (); error_code (EACCES); msglen (0); @@ -79,6 +80,8 @@ client_request_msg::serve (transport_layer_base *const conn, } /* Early revert_to_self since IPC code runs in kernel mode. */ conn->revert_to_self (); + /* sysv_msg.cc takes care of itself. */ + client->release (); thread td = { client, &_parameters.in.ipcblk, {-1, -1} }; int res; msgop_t msgop = _parameters.in.msgop; /* Get's overwritten otherwise. */ @@ -104,7 +107,6 @@ client_request_msg::serve (transport_layer_base *const conn, /* Allocated by the call to adjust_identity_info(). */ if (_parameters.in.ipcblk.gidlist) free (_parameters.in.ipcblk.gidlist); - client->release (); error_code (res); if (msgop == MSGOP_msgrcv) _parameters.out.rcv = td.td_retval[0]; -- cgit v1.2.3