diff options
| author | Christopher Faylor <me@cgf.cx> | 2004-01-23 23:05:33 +0000 |
|---|---|---|
| committer | Christopher Faylor <me@cgf.cx> | 2004-01-23 23:05:33 +0000 |
| commit | f723909038afc7657b5a19c48d64458ad0dd18d8 (patch) | |
| tree | 42581fecc70aca8fff333f8e7808fab4400a6b2b /winsup/cygwin/sigproc.cc | |
| parent | 7dddf53f5caee354852156ce552859c0bc81a3c7 (diff) | |
| download | cygnal-f723909038afc7657b5a19c48d64458ad0dd18d8.tar.gz cygnal-f723909038afc7657b5a19c48d64458ad0dd18d8.tar.bz2 cygnal-f723909038afc7657b5a19c48d64458ad0dd18d8.zip | |
* configure.in: Remove NEWVFORK default.
* configure: Regenerate.
* dcrt0.cc: Conditionalize vfork stuff throughout.
* dtable.cc: Ditto.
* perthread.h: Ditto.
* pipe.cc (fhandler_pipe::close): Ditto.
* spawn.cc (spawnve): Ditto.
* syscalls.cc (setsid): Ditto.
* exceptions.cc (sigpacket::process): Use macro to refer to vfork pid.
* debug.cc (verify_handle): Define new function.
* debug.h (VerifyHandle): Define new macro.
(verify_handle): Declare new function
* fhandler.cc (fhandler_base::dup): Verify that dup'ed handle is not supposed
to be in use.
(fhandler_base::set_inheritance): Ditto.
(fhandler_base::fork_fixup): Ditto.
* fhandler_socket.cc (fhandler_socket::dup): Ditto.
* fhandler_tty.cc (fhandler_tty_slave::open): Ditto.
* net.cc (set_socket_inheritance): Ditto.
* pinfo.cc (pinfo_fixup_after_exec): Ditto.
* sigproc.cc (proc_subproc): Ditto.
(sig_send): Ditto.
* spawn.cc (spawn_guts): Ditto.
* thread.cc (pthread::init_mainthread): Ditto.
* pipe.cc (fhandler_pipe::close): Close read_state with ForceCloseHandle since
it was protected.
(fhandler_pipe::fixup_after_exec): Protect read_state handle.
(fhandler_pipe::dup): Correctly close open handles on error condition. Verify
that dup'ed handle is not supposed to be in use.
(fhandler_pipe::create): Protect read_state.
Diffstat (limited to 'winsup/cygwin/sigproc.cc')
| -rw-r--r-- | winsup/cygwin/sigproc.cc | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc index dff2c1bd4..20a44a279 100644 --- a/winsup/cygwin/sigproc.cc +++ b/winsup/cygwin/sigproc.cc @@ -320,6 +320,7 @@ proc_subproc (DWORD what, DWORD val) if (!DuplicateHandle (hMainProc, hMainProc, vchild->hProcess, &vchild->ppid_handle, SYNCHRONIZE | PROCESS_DUP_HANDLE, TRUE, 0)) system_printf ("Couldn't duplicate my handle<%p> for pid %d, %E", hMainProc, vchild->pid); + VerifyHandle (vchild->ppid_handle); vchild->ppid = myself->pid; vchild->uid = myself->uid; vchild->gid = myself->gid; @@ -716,17 +717,19 @@ sig_send (_pinfo *p, siginfo_t& si, _threadinfo *tls) __seterrno (); goto out; } + VerifyHandle (hp); for (int i = 0; !p->sendsig && i < 10000; i++) low_priority_sleep (0); if (!DuplicateHandle (hp, p->sendsig, hMainProc, &sendsig, false, 0, DUPLICATE_SAME_ACCESS) || !sendsig) { + CloseHandle (hp); sigproc_printf ("DuplicateHandle failed, %E"); __seterrno (); goto out; } CloseHandle (hp); - pack.wakeup = NULL; + VerifyHandle (sendsig); } sigproc_printf ("sendsig %p, pid %d, signal %d, its_me %d", sendsig, p->pid, si.si_signo, its_me); |