* Makefile.in: Add cygheap.o.

* child_info.h: Add specific exec class.
* cygheap.h: New file.  Contains declarations for cygwin heap.
* cygheap.cc: New file.  Implements cygwin heap functions.
* dcrt0.cc (quoted): Simplify due to new method for passing arguments between
cygwin programs.
(alloc_stack_hard_way): Attempt to handle overlapped stack.
(dll_crt0_1): Move child_info processing here.  Accomodate new method for
passing arguments between cygwin programs.  Initialize cygwin heap.  Establish
__argc and __argv variables.
(_dll_crt0): Move most of child_info processing to dll_crt0_1.
(cygwin_dll_init): Remove duplication.
* dtable.cc (dtable::extend): Allocate dtable using cygwin heap.
(dtable::build_fhandler): Ditto for fhandler type being constructed.
(dtable::dup_worker): Free new fhandler from cygwin heap on error.
(dtable::select_*): Don't assume that this == fdtab.
(dtable::linearize_fd_array): Delete.
(dtable::delinearize_fd_array): Delete.
(dtable::fixup_after_exec): New file.
(dtable::vfork_child_dup): Use cygwin heap.
(dtable::vfork_parent_restore): Ditto.
* dtable.h: Remove obsolete methods.  Add new method.
* environ.cc (posify): Eliminate already_posix parameter and logic.
(envsize): New function.
(_addenv): Use envsize.
(environ_init): Accept an argument pointing to an existing environment list.
If supplied, allocate space for this in the the program's heap.
* fhandler.cc (fhandler_base::operator =): Move here from fhandler.h.  Use
cygwin heap to allocate filenames.
(fhandler_base::set_name): Allocate/free names from cygwin heap.
(fhandler_base::linearize): Delete.
(fhandler_base::de_linearize): Delete.
(fhandler_base::operator delete): Free from cygwin heap.
(fhandler_base::~fhandler_base): Ditto.
* fhandler.h: Accomodate elimination of *linearize and other changes above.
* fhandler_console.cc (fhandler_console::fixup_after_exec): Rename from
de_linearize.
* heap.h: New file.
* fhandler_tty.cc (fhandler_tty_slave::fhandler_tty_slave): Use cygwin heap for
name.  fhandler_tty::fixup_after_exec): Rename from de_linearize.
* fork.cc (fork): Call cygheap_fixup_in_child.
* heap.cc: Use declarations in heap.h.
* malloc.cc: Sprinkle assertions throughout to catch attempts to free/realloc
something from the cygwin heap.
* path.cc: Throughout, eliminate use of per-thread cache for cwd.  Use cwd_*
functions rather than cwd_* variables to access cwd_win32 and cwd_posix.
(cwd_win32): New function.
(cwd_posix): New function.
(cwd_hash): New function.
(cwd_fixup_after_exec): New function.
* path.h: Accomodate path.cc changes.
* pinfo.cc (pinfo_init): Accept a pointer to an environment table.  Pass this
to environ_init.  Eliminate old 'title' tests.
* pinfo.h: Accomodate above change in argument.
* spawn.cc (struct av): New method for building argv list.
(av::unshift): New method.
(spawn_guts): Allocate everything that the child process needs in the cygwin
heap and pass a pointer to this to the child.  Build argv list using new
method.  Eliminate delinearize stuff.
* thread.h: Eliminate _cwd_win32 and _cwd_posix buffers.
* winsup.h: Eliminate obsolete functions.  Add envsize() declaration.

1 files changed, 27 insertions, 25 deletions

diff --git a/winsup/cygwin/fork.cc b/winsup/cygwin/fork.cc
index 981862a83..6be5e3a25 100644
--- a/winsup/cygwin/fork.cc
+++ b/winsup/cygwin/fork.cc
@@ -22,6 +22,7 @@ details. */
 #include "sync.h"
 #include "sigproc.h"
 #include "pinfo.h"
+#include "cygheap.h"
 #include "child_info.h"
 #include "perthread.h"
 
@@ -37,14 +38,14 @@ DWORD NO_COPY chunksize = 0;
 
 void
 per_thread::set (void *s)
-  {
-    if (s == PER_THREAD_FORK_CLEAR)
-      {
-        tls = TlsAlloc ();
-	s = NULL;
-      }
-    TlsSetValue (get_tls (), s);
-  }
+{
+  if (s == PER_THREAD_FORK_CLEAR)
+    {
+      tls = TlsAlloc ();
+      s = NULL;
+    }
+  TlsSetValue (get_tls (), s);
+}
 
 static void
 stack_base (child_info_fork &ch)
@@ -356,7 +357,7 @@ fork ()
 
       hParent = NULL;
       if (!DuplicateHandle (hMainProc, hMainProc, hMainProc, &hParent, 0, 1,
-			   DUPLICATE_SAME_ACCESS))
+			    DUPLICATE_SAME_ACCESS))
 	{
 	  system_printf ("couldn't create handle to myself for child, %E");
 	  goto cleanup;
@@ -365,13 +366,13 @@ fork ()
       /* Remove impersonation */
       uid_t uid = geteuid();
       if (myself->impersonated && myself->token != INVALID_HANDLE_VALUE)
-        seteuid (myself->orig_uid);
+	seteuid (myself->orig_uid);
 
       char sa_buf[1024];
       rc = CreateProcessA (myself->progname, /* image to run */
 			   myself->progname, /* what we send in arg0 */
-                           allow_ntsec ? sec_user (sa_buf) : &sec_none_nih,
-                           allow_ntsec ? sec_user (sa_buf) : &sec_none_nih,
+			   allow_ntsec ? sec_user (sa_buf) : &sec_none_nih,
+			   allow_ntsec ? sec_user (sa_buf) : &sec_none_nih,
 			   TRUE,	  /* inherit handles from parent */
 			   c_flags,
 			   NULL,	  /* environment filled in later */
@@ -388,9 +389,9 @@ fork ()
 	  ForceCloseHandle(subproc_ready);
 	  ForceCloseHandle(forker_finished);
 	  subproc_ready = forker_finished = NULL;
-          /* Restore impersonation */
-          if (myself->impersonated && myself->token != INVALID_HANDLE_VALUE)
-            seteuid (uid);
+	  /* Restore impersonation */
+	  if (myself->impersonated && myself->token != INVALID_HANDLE_VALUE)
+	    seteuid (uid);
 	  return -1;
 	}
 
@@ -402,7 +403,7 @@ fork ()
 
       /* Restore impersonation */
       if (myself->impersonated && myself->token != INVALID_HANDLE_VALUE)
-        seteuid (uid);
+	seteuid (uid);
 
       ProtectHandle (pi.hThread);
       /* Protect the handle but name it similarly to the way it will
@@ -413,7 +414,7 @@ fork ()
 	  if (last_fork_proc)
 	    CloseHandle (last_fork_proc);
 	  if (!DuplicateHandle (hMainProc, pi.hProcess, hMainProc, &last_fork_proc,
-			        0, FALSE, DUPLICATE_SAME_ACCESS))
+				0, FALSE, DUPLICATE_SAME_ACCESS))
 	    system_printf ("couldn't create last_fork_proc, %E");
 	}
 
@@ -528,15 +529,15 @@ fork ()
       debug_printf ("pid %d, ppid %d", x, myself->ppid);
 
       /* Restore the inheritance state as in parent
-         Don't call setuid here! The flags are already set. */
+	 Don't call setuid here! The flags are already set. */
       if (myself->impersonated)
-        {
-          debug_printf ("Impersonation of child, token: %d", myself->token);
-          if (myself->token == INVALID_HANDLE_VALUE)
-            RevertToSelf (); // probably not needed
-          else if (!ImpersonateLoggedOnUser (myself->token))
-            system_printf ("Impersonate for forked child failed: %E");
-        }
+	{
+	  debug_printf ("Impersonation of child, token: %d", myself->token);
+	  if (myself->token == INVALID_HANDLE_VALUE)
+	    RevertToSelf (); // probably not needed
+	  else if (!ImpersonateLoggedOnUser (myself->token))
+	    system_printf ("Impersonate for forked child failed: %E");
+	}
 
       sync_with_parent ("after longjmp.", TRUE);
       ProtectHandle (hParent);
@@ -567,6 +568,7 @@ fork ()
 
       MALLOC_CHECK;
 
+      cygheap_fixup_in_child (hParent);
       fdtab.fixup_after_fork (hParent);
       signal_fixup_after_fork ();
       exec_fixup_after_fork ();