summaryrefslogtreecommitdiffstats
path: root/winsup/cygwin/dll_init.cc
diff options
context:
space:
mode:
authorCorinna Vinschen <corinna@vinschen.de>2015-12-15 21:43:33 +0100
committerCorinna Vinschen <corinna@vinschen.de>2016-06-24 23:32:39 +0200
commit00e9bf2bb3f2220bcf84d4f449907bd1deb2827f (patch)
tree3c2af9ed8215c30a5baef817bc4ae6f748036acf /winsup/cygwin/dll_init.cc
parentbb0fc7a2c0189ecdc38c8ba86c9ba4e8d8255765 (diff)
downloadcygnal-00e9bf2bb3f2220bcf84d4f449907bd1deb2827f.tar.gz
cygnal-00e9bf2bb3f2220bcf84d4f449907bd1deb2827f.tar.bz2
cygnal-00e9bf2bb3f2220bcf84d4f449907bd1deb2827f.zip
Fix various OS-related comments
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diffstat (limited to 'winsup/cygwin/dll_init.cc')
-rw-r--r--winsup/cygwin/dll_init.cc13
1 files changed, 6 insertions, 7 deletions
diff --git a/winsup/cygwin/dll_init.cc b/winsup/cygwin/dll_init.cc
index 7d01bf9c9..0fe5714ab 100644
--- a/winsup/cygwin/dll_init.cc
+++ b/winsup/cygwin/dll_init.cc
@@ -523,13 +523,12 @@ void dll_list::load_after_fork_impl (HANDLE parent, dll* d, int retries)
We DONT_RESOLVE_DLL_REFERENCES at first in case the DLL lands in
the wrong spot;
- NOTE: This step skips DLLs which loaded at their preferred
- address in the parent because they should behave (we already
- verified that their preferred address in the child is
- available). However, this may fail on a Vista/Win7 machine with
- ASLR active, because the ASLR base address will usually not equal
- the preferred base recorded in the dll. In this case, we should
- make the LoadLibraryExW call unconditional.
+ NOTE: This step skips DLLs which loaded at their preferred address in
+ the parent because they should behave (we already verified that their
+ preferred address in the child is available). However, this may fail
+ with ASLR active, because the ASLR base address will usually not equal
+ the preferred base recorded in the dll. In this case, we should make
+ the LoadLibraryExW call unconditional.
*/
for ( ; d; d = dlls.inext ())
if (d->handle != d->preferred_base)