diff options
| author | Corinna Vinschen <corinna@vinschen.de> | 2006-02-02 11:35:52 +0000 |
|---|---|---|
| committer | Corinna Vinschen <corinna@vinschen.de> | 2006-02-02 11:35:52 +0000 |
| commit | bb6f800d1840dfb870fa5af01c5884317330bdf6 (patch) | |
| tree | 1fd68f254cc055017e506cdb27e5cd0aaa7e1a1c | |
| parent | 49e803c0b61eda7051dfc9ee937f6c0a665c2eaf (diff) | |
| download | cygnal-bb6f800d1840dfb870fa5af01c5884317330bdf6.tar.gz cygnal-bb6f800d1840dfb870fa5af01c5884317330bdf6.tar.bz2 cygnal-bb6f800d1840dfb870fa5af01c5884317330bdf6.zip | |
* security.cc (is_group_member): Fix comment.
| -rw-r--r-- | winsup/cygwin/ChangeLog | 4 | ||||
| -rw-r--r-- | winsup/cygwin/security.cc | 11 |
2 files changed, 10 insertions, 5 deletions
diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index bc70bae6e..7d75b8a0b 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,5 +1,9 @@ 2006-02-02 Corinna Vinschen <corinna@vinschen.de> + * security.cc (is_group_member): Fix comment. + +2006-02-02 Corinna Vinschen <corinna@vinschen.de> + * security.cc (is_group_member): Use local group info type 1. Test group for being a global group or a well-known SID before adding it to the group list. Add comment. diff --git a/winsup/cygwin/security.cc b/winsup/cygwin/security.cc index 5bb067f56..f0deda11b 100644 --- a/winsup/cygwin/security.cc +++ b/winsup/cygwin/security.cc @@ -388,11 +388,12 @@ is_group_member (WCHAR *wgroup, PSID pusersid, cygsidlist &grp_list) Administrators or Users) can be members of local groups, even though MSDN states otherwise. The GUI refuses to put aliases into local groups, but the CLI interface allows it. However, a normal - logon token does not contain those 2nd order aliases, so we also - should not put them into the token group list. - Note: Allowing those 2nd order aliases in our group list renders - external tokens invalid, so that it becomes impossible to logon - with password and valid logon token. */ + logon token does not contain groups, in which the user is only + indirectly a member by being a member of an alias in this group. + So we also should not put them into the token group list. + Note: Allowing those groups in our group list renders external + tokens invalid, so that it becomes impossible to logon with + password and valid logon token. */ for (int glidx = 0; glidx < grp_list.count; ++glidx) if ((buf[bidx].lgrmi1_sidusage == SidTypeGroup || buf[bidx].lgrmi1_sidusage == SidTypeWellKnownGroup) |